Spoiler Code

Grim... · **Posted:** Tue Dec 15, 2009 16:52

Just in case it is the spoiler code that's causing my Apache to crash (which I doubt, to be honest), or maybe stopping certain threads from working, I'm going to adjust the way it works for a bit to see if it makes a difference.

This won't make a huge difference to you, viewer, but you'll have to select your spoily text now, and, importantly, it won't work on pictures.

Here, for my own reference, is the old spoiler code, in case I have to put it back:

Code:

<div style="padding: 3px; background-color: #FFFFFF; border: 1px solid #d8d8d8; font-size: 1em;"><div style="text-transform: uppercase; border-bottom: 1px solid #CCCCCC; margin-bottom: 3px; font-size: 0.8em; font-weight: bold; display: block;"><span onClick="if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') {  this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = ''; this.innerHTML = '<b>Spoiler: </b><a href='#' onClick='return false;'>hide</a>'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerHTML = '<b>Spoiler: </b><a href='#' onClick='return false;'>show</a>'; }" /><b>Spoiler: </b><a href="#" onClick="return false;">show</a></span></div><div><div style="display: none;">{TEXT}</div></div></div>

Grim... · **Posted:** Tue Dec 15, 2009 16:53

ZOMG Spoiler! Click here to view!

Testy test test!

Cras · **Joined:** 30th Mar, 2008 **Posts:** 49244

Grim... wrote:

or maybe stopping certain threads from working

There's been tons of cases of removing a spoiler 'fixing' a broken thread, so I'm pretty convinced of that link. No idea if it in any way relates to the web server falling over though.

DavPaz · **Joined:** 27th Jun, 2008 **Posts:** 38656

Grim... wrote:

ZOMG Spoiler! Click here to view!

Testy test test!

ZOMG Spoiler! Click here to view!

Ok, will do, boss.

Grim... · **Posted:** Tue Dec 15, 2009 16:56

Sorry, phone users.

kalmar · **Posted:** Tue Dec 15, 2009 17:03

It's OK, the spoilers were pretty difficult to read on the phone anyway. You can always press "quote" if you really want to see it.

Grim... · **Posted:** Tue Dec 15, 2009 17:04

kalmar wrote:

It's OK, the spoilers were pretty difficult to read on the phone anyway. You can always press "quote" if you really want to see it.

Not on good phones

BikNorton · **Joined:** 30th Mar, 2008 **Posts:** 10173

Javascript obviously shouldn't be able to kill the server, but that really should be in an include so it's just

Code:

Inline hacks like that really annoy me, Vanilla makes customisers do it too (I'm assuming it's a restriction imposed by phpBB). Then it could (I think) be cleaned up to be

Code:

function spoilerificationise(objSpan)
{
  var objDiv = objSpan.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0];
  var strHTML = "<b>Spoiler: </b><a href='#' onClick='return false;'>";
  var strDisplay = '';

  if (objDiv.style.display != '') {
    objSpan.innerHTML = strHTML + 'hide</a>';
  } else {
    strDisplay = 'none';
    objSpan.innerHTML = strHTML + 'show</a>';
  }
  objDiv.style.display = strDisplay;
}

And then someone obsessed about bandwidth could strip out whitespace and truncate varnames and so on to trim even more bytes out, even though as a .js it would (should) be cached by the browser.

Yes, it's frustrating enough that I thought I'd teach my grandmother to suck eggs rather than do something I'm getting paid for regardless.

(Co)Incidentally, I've had the forum go BLAMMO! a couple of times after posting (or maybe it's editing, I forget).

Grim... · **Posted:** Tue Dec 15, 2009 17:17

Yeah, I could actually do it properly by putting the JS in a file, but I'm too lazy

I'll make a better version some time in the new year if this doesn't make any difference.

Grim... · **Posted:** Tue Dec 15, 2009 17:20

And I'll probably do it like this:

Code:

<span class="spoiler">SPOILY TEXT</span>

Code:

$(".spoiler").toggle();

Lord, I love jQuery.

BikNorton · **Joined:** 30th Mar, 2008 **Posts:** 10173

I suppose there don't tend to be so many spoilers around that the inline stuff will impact bandwidth consumption too greatly.

I've never heard of jQuery. I might have a read, because it's of no use at all to my day job and therefore an interesting distraction. Is it server- or client- side? Or both? If it's PHP I'm going to lose interest fast.

MrChris · **Joined:** 1st Apr, 2008 **Posts:** 30498

Saint Bikolas wrote:

(Co)Incidentally, I've had the forum go BLAMMO! a couple of times after posting (or maybe it's editing, I forget).

I've had it log me out when I'e tried submitting posts, quite a few times now. I want my £2 back.

Malabelm · **Posted:** Tue Dec 15, 2009 17:29

Grim... wrote:

Code:

$(".spoiler").slideToggle(200);

Lord, I love jQuery.

FeeX.

Woo. Flashy!

Wullie · **Joined:** 27th Jun, 2008 **Posts:** 6183

ZOMG Spoiler! Click here to view!

A pleasing side effect is that I no longer feel the need to open the spoiler even though I don't want to see what it says. It's really annoying when I do that :facepalm:

kalmar · **Posted:** Tue Dec 15, 2009 17:59

Yeah.

I mean, err, 'I'm not highlighting one box'.

Tum-te-tum.

DavPaz · **Joined:** 27th Jun, 2008 **Posts:** 38656

damn phone. Damn 'non highlightable text' phone

SkyKid · **Joined:** 30th Mar, 2008 **Posts:** 98

Saint Bikolas wrote:

I've never heard of jQuery. I might have a read, because it's of no use at all to my day job and therefore an interesting distraction. Is it server- or client- side? Or both? If it's PHP I'm going to lose interest fast.

Yeah, take a look. It's client side- and essentially wraps away all the crap that made coding in JavaScript a pain because of inconsistencies between browsers. It tucks this away in a cute little event-driven interface, though the syntax is a bit unusual, so might take a bit of getting used to. If you're happy with CSS identifiers then you'll be halfway there.

It's still obviously an 'additive' technology, so a site shouldn't depend on it to function- but it can certainly be applied to help improve user interface for those users that have JS enabled, and development is pretty active, so it's likely to be around a while.

myp · **Posted:** Tue Dec 15, 2009 18:52

Pfft, reading spoilers on the iPhone is fine now it doesn't reload the whole page when opening them.

Grim... · **Posted:** Tue Dec 15, 2009 19:06

JQuery is a Javascript library, but you access things using css names, and it's lovely. In the code I posted above, for example, it looks for the class 'spoiler' and then toggles the content between visible and hidden. Note that that wouldn't actually be suitable, as it would open every spoiler on the page. The correct code would be

Code:

$('.spoiler').click(function() {
    $(this).toggle();
});

It's a lovely library.

Grim... · **Posted:** Tue Dec 15, 2009 19:09

mypsletoe wrote:

Pfft, reading spoilers on the iPhone is fine now it doesn't reload the whole page when opening them.

Huh, I didn't know it did that - crazy iPhone.
Was it actually reloading the page, or just re-rendering?

myp · **Posted:** Tue Dec 15, 2009 19:12

Grim... wrote:

mypsletoe wrote:

Pfft, reading spoilers on the iPhone is fine now it doesn't reload the whole page when opening them.

Huh, I didn't know it did that - crazy iPhone.
Was it actually reloading the page, or just re-rendering?

Pretty sure it reloaded it. It put you back up to the top of the page again, no matter where the spoiler tag was.

Cras · **Joined:** 30th Mar, 2008 **Posts:** 49244

Yeah. That was annoying.

Zardoz · **Posted:** Tue Dec 15, 2009 19:30

Grim... wiz ziz new code you are really spoiling uz.

Grim... · **Posted:** Fri Jan 08, 2010 17:04

Changed it again.

ZOMG Spoiler! Click here to view!

TEST TEST

ZOMG Spoiler! Click here to view!

TEST
TEST
TEST
TEST

Zardoz · **Posted:** Fri Jan 08, 2010 17:05

Schlick!

Malabelm · **Posted:** Fri Jan 08, 2010 17:06

Doesn't work on the iPhone — ha! Fucking shoddy phone.

edit: maybe make the title of the spoiler DIV an Anchor element?

sdg · **Posted:** Fri Jan 08, 2010 17:09

Works really well on my iPhone, nice one. Cheers.

TheVision · **Posted:** Fri Jan 08, 2010 17:15

That's very....

ZOMG Spoiler! Click here to view!

Nice!

Zardoz · **Posted:** Fri Jan 08, 2010 17:17

Myps is a

ZOMG Spoiler! Click here to view!

Zardoz · **Posted:** Fri Jan 08, 2010 17:18

Pooh blart schloooorp nothing to see here.

Cras · **Joined:** 30th Mar, 2008 **Posts:** 49244

Was that what you were trying to do?

Grim... · **Posted:** Fri Jan 08, 2010 17:35

Malabar Front wrote:

Doesn't work on the iPhone — ha! Fucking shoddy phone.

superdupergill wrote:

Works really well on my iPhone, nice one. Cheers.

...

Dimrill · **Posted:** Fri Jan 08, 2010 17:37

It doesn't work on my Nokia 4210.

sdg · **Posted:** Fri Jan 08, 2010 17:39

On my iPhone it shows the spoiler tag and when you click it the spoilered text drops down underneath it, without putting you back to the top of the page. It's very simple and nice.

Dimrill · **Posted:** Fri Jan 08, 2010 17:41

My microwave's having problems using it.

Malabelm · **Posted:** Fri Jan 08, 2010 17:42

superdupergill wrote:

On my iPhone it shows the spoiler tag and when you click it the spoilered text drops down underneath it, without putting you back to the top of the page. It's very simple and nice.

Is that on the standard site or mobile version? On the mobile version for me (haven't tested the normal one — will do so now), nothing happens when you click.

Zardoz · **Posted:** Fri Jan 08, 2010 17:43

Craster wrote:

Was that what you were trying to do?

Me? it's working now :kiss:

Zardoz · **Posted:** Fri Jan 08, 2010 17:43

superdupergill wrote:

It's very simple and nice.

Is it Dimrill?

Malabelm · **Posted:** Fri Jan 08, 2010 17:43

Okay, tested. Works on Normal BeEx on iPhone, doesn't work on Mobile version.

sdg · **Posted:** Fri Jan 08, 2010 17:44

Ah, that'll be why then. I'm on the standard version of the site, I'd actually forgotten I've not bookmarked the mobile site on this phone yet.

Dimrill · **Posted:** Fri Jan 08, 2010 17:44

I can't get it working on my mantelpiece.

Grim... · **Posted:** Fri Jan 08, 2010 18:05

Malabar Front wrote:

Okay, tested. Works on Normal BeEx on iPhone, doesn't work on Mobile version.

That makes sense. I'll fix that tomorrow.

DavPaz · **Joined:** 27th Jun, 2008 **Posts:** 38656

Doesn't work on the mobile site in the symbian browser on my nokia 5800. Not a huge problem but it'd be nice to see ze spoilz on my portable talky box

metalangel · **Posted:** Fri Jan 08, 2010 19:02

Fine in current version of Safari.

kalmar · **Posted:** Fri Jan 08, 2010 19:17

Oh, good, it does work on the iPhone too! (on normal version).

Dimrill · **Posted:** Fri Jan 08, 2010 21:07

Doesn't work on Voyager.

End of an Era · **Joined:** 25th Nov, 2008 **Posts:** 1041

ZOMG Spoiler! Click here to view!

I like the new jQuery enabled spoiler code

kalmar · **Posted:** Fri Jan 08, 2010 22:52

Works on iBrowse.

Bobbyaro · **Joined:** 18th Apr, 2008 **Posts:** 11897

My two cups and a bit of string are having problems parsing the transperambulation of pseudocosmic anti matter. Can anything be done?

Grim... · **Posted:** Sat Jan 09, 2010 17:22

DavPaz wrote:

Doesn't work on the mobile site in the symbian browser on my nokia 5800. Not a huge problem but it'd be nice to see ze spoilz on my portable talky box

That's probably because it doesn't exist there yet.
I'm not entirely sure what I'm going to do about that, to be honest.

Be Excellent To Each Other

Spoiler Code

Who is online